Added intra flag, removed duplicated call NO_JIRA#78
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
.../multi_component_hydrogen_bond_propensity/multi_component_hydrogen_bond_propensity_report.py
Show resolved
Hide resolved
.../multi_component_hydrogen_bond_propensity/multi_component_hydrogen_bond_propensity_report.py
Show resolved
Hide resolved
Alex-AMC
approved these changes
Apr 11, 2025
Contributor
Alex-AMC
left a comment
Alex-AMC
left a comment
There was a problem hiding this comment.
Very nice! looks like a good feature :)
Just a stylistic note, it won't make any massive difference
.../multi_component_hydrogen_bond_propensity/multi_component_hydrogen_bond_propensity_report.py
Outdated
Show resolved
Hide resolved
maloney-ccdc
approved these changes
Apr 11, 2025
Contributor
maloney-ccdc
left a comment
maloney-ccdc
left a comment
There was a problem hiding this comment.
Looks good to me, I have quibbled Alex's quibble
.../multi_component_hydrogen_bond_propensity/multi_component_hydrogen_bond_propensity_report.py
Outdated
Show resolved
Hide resolved
.../multi_component_hydrogen_bond_propensity/multi_component_hydrogen_bond_propensity_report.py
Outdated
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the option to ignore potential intramolecular HBonds and removed the duplicated call to get_mc_scores